Comments on Platte daddy: Calculate next weekday in Ruby on Rails

Thanks for posting this. I made a version that fi...

2011-03-31T12:22:58.917-04:00

Thanks for posting this.

I made a version that finds the next weekday.
ex: Time.next(:monday)

https://gist.github.com/896635

Since I found this by google, I'll add one mor...

2010-08-02T10:29:29.519-04:00

Since I found this by google, I'll add one more bit though the post is old. This is without a loop:

def nextweekday(original_date)
wday = original_date.wday
original_date + 1 + (wday/5)*(7-wday)
end

This seems to be working for me...

original...

2009-03-09T19:09:00.000-04:00

This seems to be working for me...

original_date += 1.days until (1..5).member?(original_date.wday)

This is just a refactor of the previous comment, please feel free to let me know if it is incorrect!

def next_weekday (timeobj)
begin
timeobj...

2007-11-09T14:39:00.000-05:00

def next_weekday (timeobj)
begin
timeobj += (60*60*24)
end until timeobj.wday != 6 && timeobj.wday != 0
timeobj
end

a tiny revision to actually make this work...

Here's a slightly more concise version

def...

2007-09-29T03:56:00.000-04:00

Here's a slightly more concise version

def next_weekday (timeobj)
begin
timeobj += (60*60*24)
end until timeobj != 6 && timeobj != 0
timeobj
end

Because the until condition is at the end that loop will run once, adding one day, no matter what. If the next day is a weekday it quits and returns the day.

If it's not a weekday it will loop until it hits the next monday and then return the day. Hopefully this is handy for someone out there!

Stephen, Ruby's Date implementation is very heavyw...

2007-03-01T16:13:00.000-05:00

Stephen, Ruby's Date implementation is very heavyweight for day-to-day use (it handles lots of odd cases in past dates, different calendars, etc.), so it's much less used than Time. I wrote this for a Rails app, where Time is the standard way to represent a date.

But you're absolutely right that this code doesn't check its assumption. Good point.

Had I learned to read as a young child I would hav...

2007-03-01T16:11:00.000-05:00

Had I learned to read as a young child I would have noticed you did specify that this was a Time object.

I would still recommend adding a check on the object being passed though.

Something along the lines of
one_day = 60 * 60 * 24 if original_date.class == Time else one_day = 1

Just in case some n00b like myself tried to throw a Date at it figuring that this method was intended to work on a date based on your choice of parameter name.

Nice code with a small flaw.

When doing add...

2007-03-01T15:40:00.000-05:00

Nice code with a small flaw.

When doing addition on a date in ruby with the '+' symbol, one day is equal to the integer 1. Instead of using one_day = 60 * 60 * 24, use 1. That is assuming you are using a Date object for original_date. If you are using a Time object for original_date your code is correct for generating the same time at the next weekday. You might want to add code to this method to check the class type of the object being passed in to be on the safe side.

Here's my crack at it. :-) def next_weekday(o...

2006-12-22T13:06:00.000-05:00

Here's my crack at it. :-)

def next_weekday(original_date)
one_day = 60 * 60 * 24
result = original_date + one_day
original_date.wday == 5 && result += one_day * 2
result
end